<div dir="ltr">Sounds good. I'll adapt my implementation.<div><br clear="all"><div><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature">behdad<br><a href="http://behdad.org/" target="_blank">http://behdad.org/</a></div></div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Apr 23, 2024 at 1:31 PM Skef Iterum <<a href="mailto:skef@skef.org">skef@skef.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><u></u>
<div>
<p>I hope not. We discussed that
<a href="https://github.com/harfbuzz/boring-expansion-spec/issues/104#issuecomment-1920031792" target="_blank">https://github.com/harfbuzz/boring-expansion-spec/issues/104#issuecomment-1920031792</a>
and decided on a convention for putting them in the<br>
MultiVarStore. That would still be my preference barring some
reason not to.</p>
<p><br>
</p>
<div>On 4/23/24 11:51, Behdad Esfahbod
wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">Also. Just confirming: are we spec'ing that all
ConditionValue's in any table should use the GDEF ItemVarStore?
This becomes important for VARC, which has a MultiItemVarStore,
but no regular ItemVarStore itself.
<div><br clear="all">
<div>
<div dir="ltr" class="gmail_signature">behdad<br>
<a href="http://behdad.org/" target="_blank">http://behdad.org/</a></div>
</div>
<br>
</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Tue, Apr 23, 2024 at
12:43 PM Behdad Esfahbod <<a href="mailto:behdad@behdad.org" target="_blank">behdad@behdad.org</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div dir="ltr">Hi Skef,
<div><br>
</div>
<div>I'm implementing the ConditionValue proposal, and have
some feedback. This is based on the following document:</div>
<div><br>
</div>
<div> <a href="https://github.com/adobe-type-tools/opentype-spec-drafts/blob/main/condvalue_spec.md" target="_blank">https://github.com/adobe-type-tools/opentype-spec-drafts/blob/main/condvalue_spec.md</a></div>
<div><span style="color:rgb(31,35,40);font-family:-apple-system,BlinkMacSystemFont,"Segoe UI","Noto Sans",Helvetica,Arial,sans-serif,"Apple Color Emoji","Segoe UI Emoji";font-size:16px"><br>
</span></div>
<div>"""</div>
<div><span style="color:rgb(31,35,40);font-family:-apple-system,BlinkMacSystemFont,"Segoe UI","Noto Sans",Helvetica,Arial,sans-serif,"Apple Color Emoji","Segoe UI Emoji";font-size:16px">In
"FeatureVariations Table", note that if minorVersion is
0 then only Condition Table version 1 can be used. If
minorVersion is 1 then Condition Table version 2 can
also be used.</span></div>
<div><span style="color:rgb(31,35,40);font-family:-apple-system,BlinkMacSystemFont,"Segoe UI","Noto Sans",Helvetica,Arial,sans-serif,"Apple Color Emoji","Segoe UI Emoji";font-size:16px">"""</span></div>
<div><font face="-apple-system, BlinkMacSystemFont, Segoe UI, Noto Sans, Helvetica, Arial, sans-serif, Apple Color Emoji, Segoe UI Emoji" color="#1f2328"><span style="font-size:16px">I highly
suggest removing this. The minorVersion is for when
new fields are added to FeatureVariations table
itself. It should not be relied on for anything else.</span></font></div>
<div><font face="-apple-system, BlinkMacSystemFont, Segoe UI, Noto Sans, Helvetica, Arial, sans-serif, Apple Color Emoji, Segoe UI Emoji" color="#1f2328"><span style="font-size:16px"><br>
</span></font></div>
<div><span style="color:rgb(31,35,40);font-family:-apple-system,BlinkMacSystemFont,"Segoe UI","Noto Sans",Helvetica,Arial,sans-serif,"Apple Color Emoji","Segoe UI Emoji";font-size:16px">"""</span></div>
<div><span style="color:rgb(31,35,40);font-family:-apple-system,BlinkMacSystemFont,"Segoe UI","Noto Sans",Helvetica,Arial,sans-serif,"Apple Color Emoji","Segoe UI Emoji";font-size:16px">Add
new subpart between "Condition Table Format 1: Font
Variation Axis Range" and "FeatureTableSubstitution
Table" with this content:</span><br>
</div>
<div><span style="color:rgb(31,35,40);font-family:-apple-system,BlinkMacSystemFont,"Segoe UI","Noto Sans",Helvetica,Arial,sans-serif,"Apple Color Emoji","Segoe UI Emoji";font-size:16px">"""</span></div>
<div><span style="color:rgb(31,35,40);font-family:-apple-system,BlinkMacSystemFont,"Segoe UI","Noto Sans",Helvetica,Arial,sans-serif,"Apple Color Emoji","Segoe UI Emoji";font-size:16px">Can
we name Format1 simply ConditionAxisRange? That would go
better with ConditionValue, ConditionAnd, ConditionOr,
and ConditionNegate.</span></div>
<div><span style="color:rgb(31,35,40);font-family:-apple-system,BlinkMacSystemFont,"Segoe UI","Noto Sans",Helvetica,Arial,sans-serif,"Apple Color Emoji","Segoe UI Emoji";font-size:16px"><br>
</span></div>
<div><span style="color:rgb(31,35,40);font-family:-apple-system,BlinkMacSystemFont,"Segoe UI","Noto Sans",Helvetica,Arial,sans-serif,"Apple Color Emoji","Segoe UI Emoji";font-size:16px">"""</span></div>
<div>On page 166: "Within the GPOS, JSTF, GDEF and BASE
tables, delta-set indices are stored in VariationIndex
tables."<br>
"""</div>
<div>I don't understand this. What is a VariationIndex
table?</div>
<div><br>
</div>
<div>Thanks,</div>
<div><br>
</div>
<div>
<div>
<div dir="ltr" class="gmail_signature">behdad<br>
<a href="http://behdad.org/" target="_blank">http://behdad.org/</a></div>
</div>
</div>
</div>
</blockquote>
</div>
</blockquote>
</div>
</blockquote></div>